linux-kernel - Re: [PATCH] drivers: staging: gpib: minor fixes for some C macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM9PR08MB61145157B28A55649F155F2AA145A@AM9PR08MB6114.eurprd08.prod.outlook.com>
Date: Fri, 27 Jun 2025 19:53:21 +0000
From: Abdalla Ahmad <Abdalla.Ahmad@...ame.org.jo>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Dave Penkler <dpenkler@...il.com>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Michael Rubin <matchstick@...erthere.org>, Arnd
 Bergmann <arnd@...db.de>, Paul Retourné
	<paul.retourne@...nge.fr>, "open list:STAGING SUBSYSTEM"
	<linux-staging@...ts.linux.dev>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: staging: gpib: minor fixes for some C macros.

Hi

> This breaks the build.
Sorry but how is this breaking the build? Putting checkpatch.pl aside, intuitively it makes sense to wrap long macros in parenthesis to avoid compile time errors and runtime bugs...

Best Regards,
Abdalla

________________________________________
From: Dan Carpenter <dan.carpenter@...aro.org>
Sent: Friday, June 27, 2025 10:39 PM
To: Abdalla Ahmad <Abdalla.Ahmad@...ame.org.jo>
Cc: Dave Penkler <dpenkler@...il.com>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Michael Rubin <matchstick@...erthere.org>; Arnd Bergmann <arnd@...db.de>; Paul Retourné <paul.retourne@...nge.fr>; open list:STAGING SUBSYSTEM <linux-staging@...ts.linux.dev>; open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: staging: gpib: minor fixes for some C macros.
 
On Fri, Jun 27, 2025 at 10:36:13PM +0300, Abdalla Al-Dalleh wrote:
> Ran checkpatch.pl on drivers/staging/gpib/, found the following:
>  - gpio: gpib_bitbang.c: wrapped LINVAL macro w/ parenthesis.
>  - hp_82341: hp_82341.c: Used comments instead of "#if 0"
>  - tnt4882: tnt4882_gpib.c: Used comments instead of "#if 0"
>
> Signed-off-by: Abdalla Al-Dalleh <abdalla.ahmad@...ame.org.jo>
> ---
>  drivers/staging/gpib/gpio/gpib_bitbang.c    |  4 ++--
>  drivers/staging/gpib/hp_82341/hp_82341.c    | 14 +++++++-------
>  drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 14 +++++++-------
>  3 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c b/drivers/staging/gpib/gpio/gpib_bitbang.c
> index 625fef24a0bf..45cf4571c58d 100644
> --- a/drivers/staging/gpib/gpio/gpib_bitbang.c
> +++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
> @@ -47,10 +47,10 @@
>                        dev_dbg(board->gpib_dev, frm, ## __VA_ARGS__); } \
>        while (0)
> 
> -#define LINVAL gpiod_get_value(DAV),         \
> +#define LINVAL (gpiod_get_value(DAV),                \
>                gpiod_get_value(NRFD),          \
>                gpiod_get_value(NDAC),          \
> -             gpiod_get_value(SRQ)
> +             gpiod_get_value(SRQ))

This breaks the build.

regards,
dan carpenter