linux-kernel - Re: [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250627203039.GA30239-robh@kernel.org>
Date: Fri, 27 Jun 2025 15:30:39 -0500
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Vladimir Zapolskiy <vz@...ia.com>,
	Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>,
	"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." <linux-input@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"moderated list:ARM/LPC32XX SOC SUPPORT" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: input: convert lpc32xx-key.txt to yaml
 format

On Tue, Jun 24, 2025 at 04:06:58PM -0400, Frank Li wrote:
> Convert lpc32xx-key.txt to yaml format.
> 
> Additional changes:
> - set maximum of key-row(column) to 4.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../devicetree/bindings/input/lpc32xx-key.txt | 34 ----------
>  .../bindings/input/nxp,lpc3220-key.yaml       | 66 +++++++++++++++++++
>  2 files changed, 66 insertions(+), 34 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/lpc32xx-key.txt
>  create mode 100644 Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> deleted file mode 100644
> index 2b075a080d303..0000000000000
> --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -NXP LPC32xx Key Scan Interface
> -
> -This binding is based on the matrix-keymap binding with the following
> -changes:
> -
> -Required Properties:
> -- compatible: Should be "nxp,lpc3220-key"
> -- reg: Physical base address of the controller and length of memory mapped
> -  region.
> -- interrupts: The interrupt number to the cpu.
> -- clocks: phandle to clock controller plus clock-specifier pair
> -- nxp,debounce-delay-ms: Debounce delay in ms
> -- nxp,scan-delay-ms: Repeated scan period in ms
> -- linux,keymap: the key-code to be reported when the key is pressed
> -  and released, see also
> -  Documentation/devicetree/bindings/input/matrix-keymap.txt
> -
> -Note: keypad,num-rows and keypad,num-columns are required, and must be equal
> -since LPC32xx only supports square matrices
> -
> -Example:
> -
> -	key@...50000 {
> -		compatible = "nxp,lpc3220-key";
> -		reg = <0x40050000 0x1000>;
> -		clocks = <&clk LPC32XX_CLK_KEY>;
> -		interrupt-parent = <&sic1>;
> -		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> -		keypad,num-rows = <1>;
> -		keypad,num-columns = <1>;
> -		nxp,debounce-delay-ms = <3>;
> -		nxp,scan-delay-ms = <34>;
> -		linux,keymap = <0x00000002>;
> -	};
> diff --git a/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml b/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
> new file mode 100644
> index 0000000000000..5ab6cefd35fa3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/nxp,lpc3220-key.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/nxp,lpc3220-key.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP LPC32xx Key Scan Interface
> +
> +maintainers:
> +  - Frank Li <Frank.Li@....com>

You need a $ref to matrix-keymap.yaml

> +
> +properties:
> +  compatible:
> +    const: nxp,lpc3220-key
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  keypad,num-rows:
> +    maximum: 4
> +
> +  keypad,num-columns:
> +    maximum: 4
> +
> +  nxp,debounce-delay-ms:
> +    description: Debounce delay in ms
> +
> +  nxp,scan-delay-ms:
> +    description: Repeated scan period in ms
> +
> +  linux,keymap: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - nxp,debounce-delay-ms
> +  - nxp,scan-delay-ms
> +  - linux,keymap
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/clock/lpc32xx-clock.h>
> +
> +    key@...50000 {
> +        compatible = "nxp,lpc3220-key";
> +        reg = <0x40050000 0x1000>;
> +        clocks = <&clk LPC32XX_CLK_KEY>;
> +        interrupt-parent = <&sic1>;
> +        interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> +        keypad,num-rows = <1>;
> +        keypad,num-columns = <1>;
> +        nxp,debounce-delay-ms = <3>;
> +        nxp,scan-delay-ms = <34>;
> +        linux,keymap = <0x00000002>;
> +    };
> -- 
> 2.34.1
>