linux-kernel - Re: [PATCH v6] coccinelle: misc: Add field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3498578-e3ef-4c63-a132-56ba6ac24900@quicinc.com>
Date: Fri, 27 Jun 2025 12:33:15 +0800
From: Luo Jie <quic_luoj@...cinc.com>
To: Markus Elfring <Markus.Elfring@....de>, <cocci@...ia.fr>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Joey Gouly <joey.gouly@....com>, Julia Lawall
	<Julia.Lawall@...ia.fr>,
        Marc Zyngier <maz@...nel.org>, Nicolas Palix
	<nicolas.palix@...g.fr>,
        Oliver Upton <oliver.upton@...ux.dev>,
        "Rasmus
 Villemoes" <linux@...musvillemoes.dk>,
        Suzuki Poulose
	<suzuki.poulose@....com>,
        Will Deacon <will@...nel.org>, Yury Norov
	<yury.norov@...il.com>,
        Zenghui Yu <yuzenghui@...wei.com>
CC: LKML <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <kvmarm@...ts.linux.dev>,
        Andrew Lunn
	<andrew@...n.ch>,
        Kiran Kumar C.S.K <quic_kkumarcs@...cinc.com>,
        Lei Wei
	<quic_leiwei@...cinc.com>,
        Pavithra R <quic_pavir@...cinc.com>,
        "Suruchi
 Agarwal" <quic_suruchia@...cinc.com>,
        <quic_linchen@...cinc.com>
Subject: Re: [PATCH v6] coccinelle: misc: Add field_modify script



On 6/26/2025 3:43 PM, Markus Elfring wrote:
>> +coccilib.report.print_report(p[0], "WARNING: Consider using FIELD_MODIFY helper on %s" % (x))
> 
> Would you find it a bit nicer to use also another formatted string literal
> as a function call parameter?
> (The recent code adjustment indicated something for the operation mode “org”.)
> https://docs.python.org/3/reference/lexical_analysis.html#f-strings
> 
> Regards,
> Markus

Sure, I agree that using a formatted string literal as a function call
parameter will make the code cleaner. I will update the function call
as shown below in the next revision.

coccilib.report.print_report(p[0], f"WARNING: Consider using 
FIELD_MODIFY helper on {x}")