linux-kernel - Re: [PATCH v11 3/4] tpm: Add a driver for Loongson TPM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86b5e396-54d4-7b36-8848-06f41083ba59@loongson.cn>
Date: Fri, 27 Jun 2025 14:46:11 +0800
From: Qunqin Zhao <zhaoqunqin@...ngson.cn>
To: Jarkko Sakkinen <jarkko@...nel.org>, Huacai Chen <chenhuacai@...nel.org>,
 Lee Jones <lee@...nel.org>, herbert@...dor.apana.org.au
Cc: linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
 davem@...emloft.net, linux-crypto@...r.kernel.org, peterhuewe@....de,
 jgg@...pe.ca, linux-integrity@...r.kernel.org,
 Yinggang Gu <guyinggang@...ngson.cn>, Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v11 3/4] tpm: Add a driver for Loongson TPM device


在 2025/6/27 上午2:29, Jarkko Sakkinen 写道:
> On Thu, Jun 26, 2025 at 08:48:35PM +0800, Huacai Chen wrote:
>> But there is another coherency, you can see this in the 1st patch:
>>
>> +static const struct mfd_cell engines[] = {
>> + { .name = "loongson-rng" },
>> + { .name = "loongson-tpm" },
>> +};
> I thought already after ffa driver from ARM that I need to fix up
> the naming a bit before it explodes. Thus, I'll stick to this.
>
> And e.g., I could easily find DRM driver with opposite order.
Next revision:

+static const struct mfd_cell engines[] = {
+	{ .name = "loongson-rng" },
+	{ .name = "tpm_loongson" },
+};
Then
"loongson-rng" can match MFD and Crypto subsystem naming convention.
"tpm_loongson" can match TPM subsystem naming convention.


Thanks,
Qunqin

>> Huacai
> BR, Jarkko