linux-kernel - Re: [PATCH] xfs: add FALLOC_FL_ALLOCATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <smvidb4nwokhjnh4g5qve3g4cu52nhrh5nslf56bjs6rp7qtug@qkuwln2srtvj>
Date: Fri, 27 Jun 2025 09:08:12 +0200
From: Carlos Maiolino <cem@...nel.org>
To: Youling Tang <youling.tang@...ux.dev>
Cc: linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Youling Tang <tangyouling@...inos.cn>
Subject: Re: [PATCH] xfs: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask

On Fri, Jun 27, 2025 at 01:33:44PM +0800, Youling Tang wrote:
> From: Youling Tang <tangyouling@...inos.cn>
> 
> Add FALLOC_FL_ALLOCATE_RANGE to the set of supported fallocate flags in
> XFS_FALLOC_FL_SUPPORTED. This change improves code clarity and maintains
> by explicitly showing this flag in the supported flags mask.
> 
> Note that since FALLOC_FL_ALLOCATE_RANGE is defined as 0x00, this addition
> has no functional modifications.
> 
> Signed-off-by: Youling Tang <tangyouling@...inos.cn>
> ---
>  fs/xfs/xfs_file.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 48254a72071b..d7f6b078d413 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -1335,7 +1335,8 @@ xfs_falloc_allocate_range(
>  }
> 
>  #define	XFS_FALLOC_FL_SUPPORTED						\
> -		(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |		\
> +		(FALLOC_FL_KEEP_SIZE |					\
> +		 FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_PUNCH_HOLE |	\
>  		 FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_ZERO_RANGE |	\
>  		 FALLOC_FL_INSERT_RANGE | FALLOC_FL_UNSHARE_RANGE)

This sounds reasonable. Could you please add it as the first flag to
keep "the right order"?

Other than this nitpick, you can add:

Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com>

> 
> --
> 2.34.1
> 
>