linux-kernel - Re: [PATCH v2 06/10] dt-bindings: clock: airoha: Document new property airoha,chip-scu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250627-determined-helpful-rabbit-be2dfe@krzk-bin>
Date: Fri, 27 Jun 2025 09:59:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, Felix Fietkau <nbd@....name>, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/10] dt-bindings: clock: airoha: Document new
 property airoha,chip-scu

On Tue, Jun 17, 2025 at 03:04:49PM +0200, Christian Marangi wrote:
> Document new property airoha,chip-scu used on new Airoha SoC to
> reference the Chip SCU syscon node used for PCIe configuration.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  .../devicetree/bindings/clock/airoha,en7523-scu.yaml      | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index fe2c5c1baf43..bce77a14c938 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -49,6 +49,11 @@ properties:
>      description: ID of the controller reset line
>      const: 1
>  
> +  airoha,chip-scu:

So the scu has phandle to scu... That's not what we discussed. Your
changelog also is very vague here, no links to previous discussions does
not make reviewing it easier.

You clearly said you have SCU node wich clocks and now you claim you
have here some different device thus you need phandle. This is what your
schema says.

No.

Where is the DTS with COMPLETE picture?

Best regards,
Krzysztof