linux-kernel - RE: [PATCH v2 1/1] iommu/vt-d: Assign devtlb cache tag on ATS enablement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276C8DA11EC1F412757E5F08C45A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Fri, 27 Jun 2025 00:00:35 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, "Will
 Deacon" <will@...nel.org>, Robin Murphy <robin.murphy@....com>, "Lin,
 Shuicheng" <shuicheng.lin@...el.com>
CC: "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v2 1/1] iommu/vt-d: Assign devtlb cache tag on ATS
 enablement

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Wednesday, June 25, 2025 1:02 PM
> 
> Commit <4f1492efb495> ("iommu/vt-d: Revert ATS timing change to fix boot
> failure") placed the enabling of ATS in the probe_finalize callback. This
> occurs after the default domain attachment, which is when the ATS cache
> tag is assigned. Consequently, the device TLB cache tag is missed when the
> domain is attached, leading to the device TLB not being invalidated in the
> iommu_unmap paths.
> 
> Fix this by assigning the CACHE_TAG_DEVTLB cache tag when ATS is enabled.
> 
> Fixes: 4f1492efb495 ("iommu/vt-d: Revert ATS timing change to fix boot
> failure")
> Cc: stable@...r.kernel.org
> Suggested-by: Kevin Tian <kevin.tian@...el.com>
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> Tested-by: Shuicheng Lin <shuicheng.lin@...el.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>