[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250627-meek-furry-mayfly-6bf0e1@krzk-bin>
Date: Fri, 27 Jun 2025 10:21:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: broonie@...nel.org, lgirdwood@...il.com, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, matthias.bgg@...il.com,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v2 5/6] dt-bindings: regulator: Document MediaTek MT6373
PMIC Regulators
On Tue, Jun 24, 2025 at 09:35:47AM +0200, AngeloGioacchino Del Regno wrote:
> +properties:
> + compatible:
> + const: mediatek,mt6373-regulator
Where is mediatek,mt6373? Nothing in cover letter explains that, but I
expect parent device schema to $ref this one or (better) mention
compatibles for child.
> +
> + interrupts:
> + description: Overcurrent warning interrupts
> + minItems: 1
> + maxItems: 35
> +
> + interrupt-names:
> + description:
> + Names for the overcurrent interrupts are the same as the name
> + of a regulator (hence the same as each regulator's node name).
> + For example, the interrupt name for regulator vs2 will be "vs2".
> + minItems: 1
> + maxItems: 35
> +
> +patternProperties:
> + "^v(ant|aud|aux)18$":
> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
You need to document what modes mean in schema with constraints and in
text with their actual meaning (see regulator.yaml).
Also: Other comments from previous patch are applicable.
Best regards,
Krzysztof
Powered by blists - more mailing lists