linux-kernel - Re: [PATCH v1 1/2] firmware: sysfb: Unorphan sysfb files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikkhd0uv.fsf@minerva.mail-host-address-is-not-set>
Date: Fri, 27 Jun 2025 10:50:48 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 linux-kernel@...r.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/2] firmware: sysfb: Unorphan sysfb files

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

Hello Andy,

> The commit d391c5827107 ("drivers/firmware: move x86 Generic
> System Framebuffers support") moved some code to the common
> folders and effectively orphaned it without any reason. Put
> it back under DRM MISC record.
>

What do you mean that it was "orphaned without any reason" ? There were no
regex matchs for the old file paths in MAINTAINERS either before that commit.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8dc0f6609d1f..c2c7aa594160 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7973,10 +7973,12 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	Documentation/devicetree/bindings/display/
>  F:	Documentation/devicetree/bindings/gpu/
>  F:	Documentation/gpu/
> +F:	drivers/firmware/sysfb*.c

I would prefer these to be in the "DRM DRIVER FOR FIRMWARE FRAMEBUFFERS"
entry instead of "DRM DRIVERS" since the former is what has most of the
code for the sysfb infrastructure.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat