linux-kernel - Re: [PATCH v4] staging: media: atomisp: remove debug sysfs attributes active_bo and free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGn2d8O-X8mgmf9kED=XbFYAoySs6+is=dorkz4yPbrSLiP6Nw@mail.gmail.com>
Date: Fri, 27 Jun 2025 12:03:39 +0300
From: Abdelrahman Fekry <abdelrahmanfekry375@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: andy@...nel.org, hdegoede@...hat.com, mchehab@...nel.org, 
	sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	linux-media@...r.kernel.org, linux-staging@...ts.linux.dev, 
	skhan@...uxfoundation.com, dan.carpenter@...aro.org, 
	Hans de Goede <hansg@...nel.org>
Subject: Re: [PATCH v4] staging: media: atomisp: remove debug sysfs attributes
 active_bo and free_bo

On Fri, Jun 27, 2025 at 11:40 AM Andy Shevchenko
<andriy.shevchenko@...el.com> wrote:
>
> On Fri, Jun 27, 2025 at 10:29:39AM +0300, Abdelrahman Fekry wrote:
> > The sysfs attributes active_bo and free_bo expose internal buffer
> > state used only for debugging purposes. These are not part of
> > any standard kernel ABI, and need to be removed before this
> > driver may be moved out of drivers/staging.
> >
> > - Remove active_bo and free_bo attributes
> > - Remove group registration calls form hmm_init() and hmm_cleanup()
>
> ...
>
> >       /* free dummy memory first */
> >       hmm_free(dummy_ptr);
> >       dummy_ptr = 0;
> > -
> >       hmm_bo_device_exit(&bo_device);
> >       hmm_initialized = false;
>
> Stray change.
>
sorry for that , will fix and resend it right away
> --
> With Best Regards,
> Andy Shevchenko
>
>