linux-kernel - Re: [PATCH 1/1] um: virt-pci: Switch to msi_create_parent_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94de787f4c3ad6fc3a44c50c2a5d5311861ddd6c.camel@sipsolutions.net>
Date: Fri, 27 Jun 2025 11:23:58 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Nam Cao <namcao@...utronix.de>
Cc: Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
 Richard Weinberger
	 <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, 
	linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] um: virt-pci: Switch to
 msi_create_parent_irq_domain()

On Fri, 2025-06-27 at 10:49 +0200, Nam Cao wrote:
> 
> Thanks for testing! The later kernel crash should be fixed with:
> 
> diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c
> index e51a9357934da..557d93aea00a1 100644
> --- a/arch/um/drivers/virt-pci.c
> +++ b/arch/um/drivers/virt-pci.c
> @@ -407,7 +407,6 @@ static const struct irq_domain_ops um_pci_inner_domain_ops = {
>  
>  #define UM_PCI_MSI_FLAGS_REQUIRED (MSI_FLAG_USE_DEF_DOM_OPS		| \
>  				   MSI_FLAG_USE_DEF_CHIP_OPS		| \
> -				   MSI_FLAG_PCI_MSI_MASK_PARENT		| \
>  				   MSI_FLAG_NO_AFFINITY)

Can confirm that.

> I have no immediate idea about the lockdep warn, I don't see how the
> MSI_FLAG_PCI_MSI_MASK_PARENT flag can be related to that. Probably there's
> another problem, let me stare at it..

Seems to go away as well, perhaps it's due to taking some wrong path
with the flag just prior to the crash?

IOW, works for me with the above change with no crash and no lockdep
warning either.

johannes