linux-kernel - Re: [PATCH v3 01/64] s390/vmlinux.lds.S: Prevent thunk functions from getting placed with normal text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250627093441.13723Cc6-hca@linux.ibm.com>
Date: Fri, 27 Jun 2025 11:34:41 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
        Petr Mladek <pmladek@...e.com>, Miroslav Benes <mbenes@...e.cz>,
        Joe Lawrence <joe.lawrence@...hat.com>, live-patching@...r.kernel.org,
        Song Liu <song@...nel.org>, laokz <laokz@...mail.com>,
        Jiri Kosina <jikos@...nel.org>,
        Marcos Paulo de Souza <mpdesouza@...e.com>,
        Weinan Liu <wnliu@...gle.com>, Fazla Mehrab <a.mehrab@...edance.com>,
        Chen Zhongjin <chenzhongjin@...wei.com>,
        Puranjay Mohan <puranjay@...nel.org>,
        Dylan Hatch <dylanbhatch@...gle.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>
Subject: Re: [PATCH v3 01/64] s390/vmlinux.lds.S: Prevent thunk functions
 from getting placed with normal text

On Thu, Jun 26, 2025 at 04:54:48PM -0700, Josh Poimboeuf wrote:
> The s390 indirect thunks are placed in the .text.__s390_indirect_jump_*
> sections.
> 
> Certain config options which enable -ffunction-sections have a custom
> version of the TEXT_TEXT macro:
> 
>   .text.[0-9a-zA-Z_]*
> 
> That unintentionally matches the thunk sections, causing them to get
> grouped with normal text rather than being handled by their intended
> rule later in the script:
> 
>   *(.text.*_indirect_*)
> 
> Fix that by adding another period to the thunk section names, following
> the kernel's general convention for distinguishing code-generated text
> sections from compiler-generated ones.
> 
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>
> ---
>  arch/s390/include/asm/nospec-insn.h | 2 +-
>  arch/s390/kernel/vmlinux.lds.S      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Heiko Carstens <hca@...ux.ibm.com>