linux-kernel - Re: [PATCH v3 46/64] x86/extable: Define ELF section entry size for exception table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250627105205.GY1613200@noisy.programming.kicks-ass.net>
Date: Fri, 27 Jun 2025 12:52:05 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Petr Mladek <pmladek@...e.com>, Miroslav Benes <mbenes@...e.cz>,
	Joe Lawrence <joe.lawrence@...hat.com>,
	live-patching@...r.kernel.org, Song Liu <song@...nel.org>,
	laokz <laokz@...mail.com>, Jiri Kosina <jikos@...nel.org>,
	Marcos Paulo de Souza <mpdesouza@...e.com>,
	Weinan Liu <wnliu@...gle.com>,
	Fazla Mehrab <a.mehrab@...edance.com>,
	Chen Zhongjin <chenzhongjin@...wei.com>,
	Puranjay Mohan <puranjay@...nel.org>,
	Dylan Hatch <dylanbhatch@...gle.com>
Subject: Re: [PATCH v3 46/64] x86/extable: Define ELF section entry size for
 exception table

On Thu, Jun 26, 2025 at 04:55:33PM -0700, Josh Poimboeuf wrote:

> @@ -193,7 +193,8 @@ static __always_inline __pure void *rip_rel_ptr(void *p)
>  	".purgem extable_type_reg\n"
>  
>  # define _ASM_EXTABLE_TYPE(from, to, type)			\
> -	" .pushsection \"__ex_table\",\"a\"\n"			\
> +	" .pushsection __ex_table, \"aM\", @progbits, "		\
> +		       __stringify(EXTABLE_SIZE) "\n"		\
>  	" .balign 4\n"						\
>  	" .long (" #from ") - .\n"				\
>  	" .long (" #to ") - .\n"				\
> @@ -201,7 +202,8 @@ static __always_inline __pure void *rip_rel_ptr(void *p)
>  	" .popsection\n"
>  
>  # define _ASM_EXTABLE_TYPE_REG(from, to, type, reg)				\
> -	" .pushsection \"__ex_table\",\"a\"\n"					\
> +	" .pushsection __ex_table, \"aM\", @progbits, "				\
> +		       __stringify(EXTABLE_SIZE) "\n"				\
>  	" .balign 4\n"								\
>  	" .long (" #from ") - .\n"						\
>  	" .long (" #to ") - .\n"						\

This style is much better.