linux-kernel - Re: [PATCH v4 2/3] x86/sev: fix error handling in sev_es_efi_map_ghcbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250627120122.GBaF6IEgLEmfntS7qA@fat_crate.local>
Date: Fri, 27 Jun 2025 14:01:22 +0200
From: Borislav Petkov <bp@...en8.de>
To: Gerd Hoffmann <kraxel@...hat.com>
Cc: linux-coco@...ts.linux.dev, kvm@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] x86/sev: fix error handling in
 sev_es_efi_map_ghcbs_caas()

On Thu, Jun 26, 2025 at 01:40:12PM +0200, Gerd Hoffmann wrote:
> -		if (kernel_map_pages_in_pgd(pgd, pfn, address, 1, pflags))
> -			return 1;
> +		retval = kernel_map_pages_in_pgd(pgd, pfn, address, 1, pflags);
> +		if (retval != 0)
> +			return retval;

Yeah, I'd understand if it made any sense to propagate the error upwards but
this function is called exactly once by efi_setup_page_tables() and all it
needs to return is success/failure which the caller uses on the spot.

So no point in doing any of that nonsense. I'll zap it from the set.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette