[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+V-a8tR=bWEwA1+iGHZojN-yPDORAR-hER-Euk-rVSQhn=CKw@mail.gmail.com>
Date: Fri, 27 Jun 2025 13:56:46 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>, Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Magnus Damm <magnus.damm@...il.com>,
Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-arm-kernel@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
Biju Das <biju.das.jz@...renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v12 1/7] dt-bindings: serial: Added secondary clock for
RZ/T2H RSCI
Hi Rob,
On Fri, Jun 27, 2025 at 12:09 AM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, Jun 17, 2025 at 02:44:58PM +0100, Prabhakar wrote:
> > From: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> >
> > At boot, the default clock is the PCLKM core clock (synchronous
> > clock, which is enabled by the bootloader).
> > For different baudrates, the asynchronous clock input must be used.
> > Clock selection is made by an internal register of RCSI.
> >
> > Add the optional "sck", external clock input.
> >
> > Also remove the unneeded serial0 alias from the dts example.
> >
> > Signed-off-by: Thierry Bultel <thierry.bultel.yh@...renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > Hi Rob,
> > As mentioned in the thread [1] below there are no users of the RSCI binding
> > hence this change doesn not break any ABI.
> >
> > [1] https://lore.kernel.org/all/CAMuHMdUThuWxxznhjvcn5cOFCWOkb5u-fRYwTOoenDRY=4H6FA@mail.gmail.com/
>
> Please state this in the commit message. If you want to break the ABI
> you have to say that you are and why it is okay.
>
Sure, I'll update the commit message and send a new version.
Cheers,
Prabhakar
Powered by blists - more mailing lists