linux-kernel - Re: [PATCH v3] perf build: Specify that shellcheck should use the bash dialect.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871pr4le4e.fsf@gmail.com>
Date: Fri, 27 Jun 2025 20:49:21 -0700
From: Collin Funk <collin.funk1@...il.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,  Ingo Molnar <mingo@...hat.com>,
  Arnaldo Carvalho de Melo <acme@...nel.org>,  Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>,  Jiri Olsa <jolsa@...nel.org>,  Ian
 Rogers <irogers@...gle.com>,  Adrian Hunter <adrian.hunter@...el.com>,
  "Liang, Kan" <kan.liang@...ux.intel.com>,  James Clark
 <james.clark@...aro.org>,  Charlie Jenkins <charlie@...osinc.com>,  Ravi
 Bangoria <ravi.bangoria@....com>,  "Masami Hiramatsu (Google)"
 <mhiramat@...nel.org>,  linux-perf-users@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] perf build: Specify that shellcheck should use the
 bash dialect.

Collin Funk <collin.funk1@...il.com> writes:

> Oops, I assumed that on a system without shellcheck NO_SHELLCHECK would
> be defined. Let me write another version.
>
> I think the 'command -v' change is best left for a separate patch(s).
> Since it is used in many other places, and maybe others will raise
> objections.

Okay, I sent V4 which makes sure SHELLCHECK is empty when the program
doesn't exist [1]. If it does exist, we then check the version. If it
does exit and is a supported version, we add the options, or else we set
it to empty.

Collin

[1] https://lore.kernel.org/linux-perf-users/63491dbc8439edf2e949d80e264b9d22332fea61.1751082075.git.collin.funk1@gmail.com/T/#u