linux-kernel - Re: [PATCH v2 0/3] replace `allow(...)` lints with `expect(...)`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250628070345.5499a7bf@nimda.home>
Date: Sat, 28 Jun 2025 07:03:45 +0300
From: Onur <work@...rozkan.dev>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-kselftest@...r.kernel.org,
 kunit-dev@...glegroups.com, airlied@...il.com, simona@...ll.ch,
 ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org,
 a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu,
 rafael@...nel.org, viresh.kumar@...aro.org, gregkh@...uxfoundation.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 davidgow@...gle.com, nm@...com
Subject: Re: [PATCH v2 0/3] replace `allow(...)` lints with `expect(...)`

On Fri, 27 Jun 2025 17:55:41 +0200
Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:

> On Fri, Jun 27, 2025 at 8:54 AM Onur Özkan <work@...rozkan.dev> wrote:
> >
> > The `#[allow(clippy::non_send_fields_in_send_ty)]` removal was
> > tested on 1.81 and clippy was still happy with it. I couldn't test
> > it on 1.78 because when I go below 1.81 `menuconfig` no longer
> > shows the Rust option. And any manual changes I make to `.config`
> > are immediately reverted on `make` invocations.
> 
> For that, I recommend using the `/` command inside `menuconfig` -- it
> allows you to see the dependencies of a given symbol, and whether they
> are met or not. That way, it allows one to understand what else may be
> missing to enable a symbol.
> 
> I hope that helps.
> 
> Cheers,
> Miguel

I already tried that but it didn't helped. I was able to make it work
with manually hacking the `init/Kconfig` file.

Removal of `#[allow(clippy::non_send_fields_in_send_ty)]` still works
as expected, but using `#![expect(internal_features)]` (which was done
in the first diff) doesn't work on 1.78. I will revert that and send v3
patch in a short.


Regards,
Onur