linux-kernel - Re: [PATCH v2] btrfs: replace nested usage of min & max with clamp in btrfs_compress_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b316d443-107d-4c85-81cf-37fe653cc8a6@gmx.com>
Date: Sat, 28 Jun 2025 14:56:42 +0930
From: Qu Wenruo <quwenruo.btrfs@....com>
To: George Hu <integral@...hlinux.org>, wqu@...e.com
Cc: clm@...com, dsterba@...e.com, josef@...icpanda.com,
 linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] btrfs: replace nested usage of min & max with clamp in
 btrfs_compress_set_level()



在 2025/6/28 14:51, George Hu 写道:
> Refactor the btrfs_compress_set_level() function by replacing the
> nested usage of min() and max() macro with clamp() to simplify the
> code and improve readability.
> 
> Signed-off-by: George Hu <integral@...hlinux.org>

Reviewed-by: Qu Wenruo <wqu@...e.com>

And merged into for-next branch.

Thanks,
Qu

> ---
>   fs/btrfs/compression.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
> index 48d07939fee4..be8d51c53f39 100644
> --- a/fs/btrfs/compression.c
> +++ b/fs/btrfs/compression.c
> @@ -975,7 +975,7 @@ static int btrfs_compress_set_level(unsigned int type, int level)
>   	if (level == 0)
>   		level = ops->default_level;
>   	else
> -		level = min(max(level, ops->min_level), ops->max_level);
> +		level = clamp(level, ops->min_level, ops->max_level);
>   
>   	return level;
>   }