[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025062815-resolute-cornflake-48c4@gregkh>
Date: Sat, 28 Jun 2025 07:08:46 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Abdalla Al-Dalleh <abdalla.ahmad@...ame.org.jo>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>,
Gabriel Shahrouzi <gshahrouzi@...il.com>,
open list <linux-kernel@...r.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@...r.kernel.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>
Subject: Re: [PATCH] drivers: staging: iio: frequency: ad9832.h: Fixed TODO
note.
On Fri, Jun 27, 2025 at 08:51:14PM +0300, Abdalla Al-Dalleh wrote:
> - drivers/staging/iio/frequency/ad9832.c: Changed .h file location
> - drivers/staging/iio/frequency/ad9832.h: Removed struct definition
> - include/linux/iio/dac/ad9832.h: Added header file according to the
> TODO note.
>
> Signed-off-by: Abdalla Al-Dalleh <abdalla.ahmad@...ame.org.jo>
> ---
> drivers/staging/iio/frequency/ad9832.c | 3 +--
> drivers/staging/iio/frequency/ad9832.h | 23 ------------------
> include/linux/iio/dac/ad9832.h | 33 ++++++++++++++++++++++++++
Staging drivers need to be "self-contained" for now.
Why do you even need a .h file for a single .c file anyway? Why not
just remove it?
thanks,
greg k-h
Powered by blists - more mailing lists