linux-kernel - Re: [PATCH v5 0/2] Bluetooth: mediatek: add gpio pin to reset bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rthuekbpdfszo2mw4b4zgjlv2nd45zbzzpxdjjxf6gpkrc5g5l@m7kfo7s4ltqv>
Date: Sat, 28 Jun 2025 14:03:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhangchao Zhang <ot_zhangchao.zhang@...iatek.com>
Cc: Marcel Holtmann <marcel@...tmann.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, Luiz Von Dentz <luiz.dentz@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Sean Wang <sean.wang@...iatek.com>, 
	Jiande Lu <jiande.lu@...iatek.com>, Deren Wu <deren.Wu@...iatek.com>, 
	Chris Lu <chris.lu@...iatek.com>, Hao Qin <Hao.qin@...iatek.com>, 
	linux-bluetooth <linux-bluetooth@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-mediatek <linux-mediatek@...ts.infradead.org>, 
	devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 0/2] Bluetooth: mediatek: add gpio pin to reset bt

On Fri, Jun 27, 2025 at 01:59:22PM +0800, Zhangchao Zhang wrote:
> The enhanced BT reset feature builds upon the previous software-based
> BT reset by adding support for hardware pin resets.
> To maintain compatibility with existing projects that
> still use the software BT reset, both methods are supported.
> 
> When performing a BT reset, the system first checks whether the
> Device Tree Source (DTS) is configured with the appropriate settings.
> If the specified compatible and BT reset GPIO are defined in the DTS,
> the system will pull the designated GPIO pin low for at least 200ms,
> then pull it high to trigger the BT reset. If these settings are not
> configured, the system will fall back to the original software
> BT reset methods.
> 
> Compared with the previously submitted version, the following
> information are some specific revision histories
> 
> V4-->V5 modifications:
> -Modify the comments mentioned in v1.

What? This is so vague, means nothing.

> -Modify dt_binding files and 
>    make dt binding a separate patch.

This means nothing. Everything is "modify". Your changelog is terribly
uninforming. This must be detailed.

Best regards,
Krzysztof