linux-kernel - Re: [PATCH] dt-bindings: iio: pressure: invensense,icp101xx: add binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250628162024.5316e66e@jic23-huawei>
Date: Sat, 28 Jun 2025 16:20:24 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
 jmaneyrol@...ensense.com, ~lkcamp/patches@...ts.sr.ht,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, Jean-Baptiste
 Maneyrol <Jean-Baptiste.Maneyrol@....com>
Subject: Re: [PATCH] dt-bindings: iio: pressure: invensense,icp101xx: add
 binding

On Thu, 26 Jun 2025 18:12:25 -0300
Rodrigo Gobbi <rodrigo.gobbi.7@...il.com> wrote:

> There is no txt file for it, add yaml for invensense,icp101xx family
> which is already used in the driver.

Don't mention binding in patch title. The dt-bindings prefix makes that obvious.

> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> ---
> Very simple yaml for a i2c device with psu. The pin out for the rest of
> the family (the other PNs) doesn`t change anything here, since the diff
> were RESV pins (unused).
> 
> This yaml file falls in the same `category` as others that I`ve submitted, the
> driver author, which might be still interested at this hardware, is no long contributing
> (at least for what I`ve looked). Also, it`s email is still "at invensense", not "at tdk", either
> way I`ll ping him here due the mention at the "maintainers" field:

Try a search for their name in recent mails to the list.  +CC Jean-Baptiste at new TDK address.
People don't always remember to send a mailmap update when their company email
changes, particularly if it is due to an acquisition.

Jean-Baptiste has been active in the last week so not hard to find!

> 
> Dear @Jean-Baptiste Maneyrol, I`ve noticed that since the driver was added,
> there was no binding doc for it and this is what this patch is addressing.
> In this case, a maintainer ref is required inside the .yaml file and I would
> like to ask if I can add you in this case.
> I would appreciate your comment or suggestion over this topic.
> 
> Tks all and regards.
> ---
>  .../iio/pressure/invensense,icp101xx.yaml     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/invensense,icp101xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/invensense,icp101xx.yaml b/Documentation/devicetree/bindings/iio/pressure/invensense,icp101xx.yaml
> new file mode 100644
> index 000000000000..439f8aaafbd2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/invensense,icp101xx.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/invensense,icp101xx.yaml#

No wild cards in file names please.  Just pick a device to name the binding
after.  Wild cards have an annoying habit of getting messed up by companies
releasing completely non compatible parts in the middle of what we thought
was a reserved number range.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: InvenSense ICP-101xx Barometric Pressure Sensors
> +
> +maintainers:
> +  - Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>

I'd assume switch to the TDK address +CC but I'll need an Ack or RB from Jean-Baptiste.

> +
> +description: |
> +  Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
> +  Those devices uses a simple I2C communication bus, measuring the pressure
> +  in a ultra-low noise at the lowest power.
> +  Datasheet: https://product.tdk.com/system/files/dam/doc/product/sensor/pressure/capacitive-pressure/data_sheet/ds-000186-icp-101xx.pdf
> +
> +properties:
> +  compatible:
> +    const: invensense,icp10100
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        pressure@63 {
> +            compatible = "invensense,icp10100";
> +            reg = <0x63>;
> +            vdd-supply = <&vdd_1v8>;
> +        };
> +    };
> +...