linux-kernel - Re: [PATCH] Squashfs: add page cache share support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506282334.A6g9vp33-lkp@intel.com>
Date: Sun, 29 Jun 2025 00:00:41 +0800
From: kernel test robot <lkp@...el.com>
To: Bo Liu <liubo03@...pur.com>, phillip@...ashfs.org.uk
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Bo Liu <liubo03@...pur.com>
Subject: Re: [PATCH] Squashfs: add page cache share support

Hi Bo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.16-rc3]
[also build test WARNING on linus/master next-20250627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bo-Liu/Squashfs-add-page-cache-share-support/20250626-084010
base:   v6.16-rc3
patch link:    https://lore.kernel.org/r/20250626003644.3675-1-liubo03%40inspur.com
patch subject: [PATCH] Squashfs: add page cache share support
config: hexagon-randconfig-r073-20250628 (https://download.01.org/0day-ci/archive/20250628/202506282334.A6g9vp33-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project e04c938cc08a90ae60440ce22d072ebc69d67ee8)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506282334.A6g9vp33-lkp@intel.com/

New smatch warnings:
fs/squashfs/inode.c:97 squashfs_iget() warn: inconsistent indenting

Old smatch warnings:
fs/squashfs/inode.c:293 squashfs_read_inode() warn: missing unwind goto?

vim +97 fs/squashfs/inode.c

    74	
    75	
    76	struct inode *squashfs_iget(struct super_block *sb, long long ino,
    77					unsigned int ino_number)
    78	{
    79		struct inode *inode = iget_locked(sb, ino_number);
    80		int err;
    81	
    82		TRACE("Entered squashfs_iget\n");
    83	
    84		if (!inode)
    85			return ERR_PTR(-ENOMEM);
    86		if (!(inode->i_state & I_NEW))
    87			return inode;
    88	
    89		err = squashfs_read_inode(inode, ino);
    90		if (err) {
    91			iget_failed(inode);
    92			return ERR_PTR(err);
    93		}
    94		unlock_new_inode(inode);
    95	
    96	#ifdef CONFIG_SQUASHFS_PAGE_CACHE_SHARE
  > 97			if ((inode->i_mode & S_IFMT) == S_IFREG) {
    98				if (squashfs_pcs_fill_inode(inode) > 0)
    99					inode->i_fop = &squashfs_pcs_file_fops;
   100			}
   101	#endif
   102	
   103		return inode;
   104	}
   105	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki