[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250628170839.482a3d63@jic23-huawei>
Date: Sat, 28 Jun 2025 17:08:39 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Lothar Rubusch <l.rubusch@...il.com>, lars@...afoo.de,
Michael.Hennerich@...log.com, dlechner@...libre.com, nuno.sa@...log.com,
andy@...nel.org, corbet@....net, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
eraretuya@...il.com
Subject: Re: [PATCH v10 4/7] iio: accel: adxl345: add inactivity feature
> ...
>
> > + case ADXL345_INACTIVITY:
> > + axis_ctrl = ADXL345_INACT_X_EN | ADXL345_INACT_Y_EN |
> > + ADXL345_INACT_Z_EN;
>
> Consider
> axis_ctrl =
> ADXL345_INACT_X_EN | ADXL345_INACT_Y_EN | ADXL345_INACT_Z_EN;
>
> (yes, I see that it's longer than 80, but it might worth doing it for the sake of
> consistency with the previous suggestion).
Hmm. I'd go longer rather than do that just because it looks really ugly.
axis_ctrl = ADXL345_INACT_X_EN | ADXL345_INACT_Y_EN | ADXL345_INACT_Z_EN;
I don't care that much as long as long lines are justified by readability. Here
I think either Andy's suggestion or the all on one line are justified.
Tomorrow I may have a different view :(
Powered by blists - more mailing lists