linux-kernel - Re: [PATCH 6/8] dt-bindings: auxdisplay: add Titan Micro Electronics TM16XX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADsqogCLjN1YQ_G+KXAkauoSdFiH+OLyh5UVAvT261sD2LO0Ng@mail.gmail.com>
Date: Sat, 28 Jun 2025 17:06:01 -0400
From: Jean-Francois Lessard <jefflessard3@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Andy Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Boris Gjenero <boris.gjenero@...il.com>, 
	Heiner Kallweit <hkallweit1@...il.com>, linux-leds@...r.kernel.org, 
	Christian Hewitt <christianshewitt@...il.com>, Andreas Färber <afaerber@...e.de>, 
	Paolo Sabatino <paolo.sabatino@...il.com>, devicetree@...r.kernel.org, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 6/8] dt-bindings: auxdisplay: add Titan Micro Electronics TM16XX

On Sat, Jun 28, 2025 at 1:55 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
>
> On Sat, 28 Jun 2025 12:18:43 -0400, Jean-François Lessard wrote:
> > Add documentation for TM16XX and compatible LED display controllers.
> >
> > This patch is inspired by previous work from Andreas Färber and Heiner Kallweit.
> >
> > Co-developed-by: Andreas Färber <afaerber@...e.de>
> > Co-developed-by: Heiner Kallweit <hkallweit1@...il.com>
> > Signed-off-by: Jean-François Lessard <jefflessard3@...il.com>
> > ---
> >  .../bindings/auxdisplay/tm16xx.yaml           | 153 ++++++++++++++++++
> >  1 file changed, 153 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/auxdisplay/tm16xx.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/auxdisplay/tm16xx.example.dts:59.29-83.11: ERROR (duplicate_label): /example-1/spi: Duplicate label 'display_client' on /example-1/spi and /example-0/i2c
> ERROR: Input tree has errors, aborting (use -f to force output)
> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/auxdisplay/tm16xx.example.dtb] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>

Thank you for the dt_binding_check feedback – I’ll prepare v2 shortly
fixing the duplicate label issue.

> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250628161850.38865-7-jefflessard3@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>

Before I send v2, I’d like your guidance on one specific design question:

Currently, the binding uses a 'tm16xx,' prefix for properties
describing hardware layout (e.g. tm16xx,digits). TM16xx being the
family name for these compatible controllers (Titanmec, Fuda Hisi,
Princeton, Winrise, i-Core).

1. Is using 'tm16xx,' as a class prefix appropriate here, or should I
instead use a vendor-specific prefix (e.g. 'titanmec,') despite
multiple vendors implementing this hardware design?

2. Should 'tm16xx' also be formally added to vendor-prefixes.yaml or
handled differently?

Your advice will ensure the next revision aligns with DT conventions.

Thanks again for your review and guidance.