[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <eemnoitjhvt3nkt6k66dl6p75zqvsdttalyncfg2dqs2bcbkgy@pvr5wgx3x5xz>
Date: Sun, 29 Jun 2025 19:53:12 +0530
From: Abdun Nihaal <abdun.nihaal@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: andy@...nel.org, dan.carpenter@...aro.org, gregkh@...uxfoundation.org,
lorenzo.stoakes@...cle.com, tzimmermann@...e.de, riyandhiman14@...il.com,
willy@...radead.org, notro@...nnes.org, thomas.petazzoni@...e-electrons.com,
dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org, Andy Shevchenko <andriy.shevchenko@...el.com>
Subject: Re: [PATCH v2 2/2] staging: fbtft: cleanup error handling in
fbtft_framebuffer_alloc()
On Sat, Jun 28, 2025 at 10:58:20PM +0300, Andy Shevchenko wrote:
> > + struct fbtft_par *par = info->par;
> > +
> > + if (par->txbuf.len > 0)
>
> Do we really need this check? If txbuf.buf is kept NULL (please, check
> this), the kfree() is NULL-aware.
I assumed that the par->txbuf.buf may be uninitialized, but I checked it
now and it uses kzalloc to allocate, so it must be NULL to begin with.
I'll remove the check, and send a v3.
Regards,
Nihaal
Powered by blists - more mailing lists