linux-kernel - Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250629171908.122a5163@jic23-huawei>
Date: Sun, 29 Jun 2025 17:19:08 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Angelo Dureghello <adureghello@...libre.com>
Cc: Nuno Sa <nuno.sa@...log.com>, Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>, David Lechner
 <dlechner@...libre.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: adc: adi,ad7606: fix dt_schema
 validation warning

On Sat, 31 May 2025 17:04:48 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Mon, 26 May 2025 15:19:08 +0200
> Angelo Dureghello <adureghello@...libre.com> wrote:
> 
> > From: Angelo Dureghello <adureghello@...libre.com>
> > 
> > Fix following dt_schema warning when offload is used:
> > 
> >   DTC [C] arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb
> > /home/angelo/dev-baylibre/linux-iio/arch/arm/boot/dts/xilinx/zynq-zed-adv7511-ad7606.dtb: adc@0: 'oneOf' conditional failed, one must be fixed:
> > 	'interrupts' is a required property
> > 	'io-backends' is a required property
> > 	from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml#
> > 
> > There isn't any reason that we couldn't have interrupts wired up at the
> > same time we are using io-backends or SPI offload, so dropping off the
> > related "oneOf" block entirely.
> > 
> > Fixes: ccf8c3f106a2 ("dt-bindings: iio: adc: adi,ad7606: add SPI offload properties")  
> That ID seems to be wrong.   Probably down to the messy rebase I had to do pre pull
> request.  Fixed up to be 81fe5529e812
> 
> Applied to the fixes-togreg-for-6.16 branch that will become fixes-togreg after rc1
> is available to rebase on.
I guess something related to the rebase I had to do just before the last
merge window caused it, but that Fixes sha is wrong.


> 
> Thanks,
> 
> Jonathan
> 
> > Signed-off-by: Angelo Dureghello <adureghello@...libre.com>
> > ---
> > Fix dt_schema validation warning.
> > 
> > Link: https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> > ---
> > Changes in v2:
> > - Change removing the related oneOf block. 
> > - Link to v1: https://lore.kernel.org/r/20250523-wip-bl-ad7606-dtschema-fixes-v1-1-d9147fb2a199@baylibre.com
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > index 29f12d650442b8ff2eb455306ce59a0e87867ddd..1a5209139e1338f803c66ad2b4d63ad53cc11d96 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> > @@ -223,12 +223,6 @@ allOf:
> >        - required:
> >            - pwms
> >  
> > -  - oneOf:
> > -      - required:
> > -          - interrupts
> > -      - required:
> > -          - io-backends
> > -
> >    - if:
> >        properties:
> >          compatible:
> > 
> > ---
> > base-commit: 3964c6e5877f054497ffccc7d00f8f7add307d0d
> > change-id: 20250523-wip-bl-ad7606-dtschema-fixes-5e6ab342e043
> > 
> > Best regards,  
> 
>