linux-kernel - Re: [PATCH] iio: accel: mma9553: make mma9553_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250629174549.1dc6ab33@jic23-huawei>
Date: Sun, 29 Jun 2025 17:45:49 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Nuno Sá <nuno.sa@...log.com>, Andy Shevchenko
 <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: accel: mma9553: make mma9553_event_info const

On Sat, 28 Jun 2025 11:00:07 -0500
David Lechner <dlechner@...libre.com> wrote:

> Add const qualifier to struct mma9553_event_info mma9553_event_info[].
> This is read-only data so it can be made const.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>

Seems fine to me. Applied to the togreg branch of iio.git
and pushed out as testing.

This one was a little fiddly to check though so more eyes
would still be good!

Jonathan

> ---
>  drivers/iio/accel/mma9553.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index ffb0d6ff37124e5f364168c5c4f348a02d28842a..f85384a7908f253f9ed55dae4e0a41a39ae6016b 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -97,7 +97,7 @@ enum activity_level {
>  	ACTIVITY_RUNNING,
>  };
>  
> -static struct mma9553_event_info {
> +static const struct mma9553_event_info {
>  	enum iio_chan_type type;
>  	enum iio_modifier mod;
>  	enum iio_event_direction dir;
> @@ -152,7 +152,7 @@ static struct mma9553_event_info {
>  #define MMA9553_EVENTS_INFO_SIZE ARRAY_SIZE(mma9553_events_info)
>  
>  struct mma9553_event {
> -	struct mma9553_event_info *info;
> +	const struct mma9553_event_info *info;
>  	bool enabled;
>  };
>  
> 
> ---
> base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
> change-id: 20250628-iio-const-data-2-7d2afbbe7f88
> 
> Best regards,