[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250629165712.GJ24912@pendragon.ideasonboard.com>
Date: Sun, 29 Jun 2025 19:57:12 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: git@...tzsch.eu
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
Ricardo Ribalda <ribalda@...nel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] media: i2c: imx214: Drop dev argument from
imx214_parse_fwnode()
On Sun, Jun 29, 2025 at 04:49:21PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@...tzsch.eu>
>
> The device can be accessed from struct imx214.
>
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
> drivers/media/i2c/imx214.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 8e9b5c9c93b0888f3d6be857168711edaf050db3..d9193bafa3cbb8fec2679200c38d30077d1b11bd 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -1324,10 +1324,11 @@ static int imx214_identify_module(struct imx214 *imx214)
> return 0;
> }
>
> -static int imx214_parse_fwnode(struct device *dev, struct imx214 *imx214)
> +static int imx214_parse_fwnode(struct imx214 *imx214)
> {
> struct v4l2_fwnode_endpoint *bus_cfg = &imx214->bus_cfg;
> struct fwnode_handle *endpoint;
> + struct device *dev = imx214->dev;
> unsigned int i;
> int ret;
>
> @@ -1415,7 +1416,7 @@ static int imx214_probe(struct i2c_client *client)
> return dev_err_probe(dev, PTR_ERR(imx214->regmap),
> "failed to initialize CCI\n");
>
> - ret = imx214_parse_fwnode(dev, imx214);
> + ret = imx214_parse_fwnode(imx214);
> if (ret)
> return ret;
>
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists