linux-kernel - Re: [PATCH] iio: common: hid-sensor-attributes: make unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250629180721.32eb61b7@jic23-huawei>
Date: Sun, 29 Jun 2025 18:07:21 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Nuno Sá <nuno.sa@...log.com>, Andy Shevchenko
 <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Jiri Kosina <jikos@...nel.org>, Srinivas Pandruvada
 <srinivas.pandruvada@...ux.intel.com>
Subject: Re: [PATCH] iio: common: hid-sensor-attributes: make
 unit_conversion const

On Sat, 28 Jun 2025 12:09:26 -0500
David Lechner <dlechner@...libre.com> wrote:

> Add const qualifier to struct unit_conversion[]. This is read-only data
> so it can be made const.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
Applied as seems to be 'obviously correct'.

+CC rest of the hid-sensors maintainers. 


> ---
>  drivers/iio/common/hid-sensors/hid-sensor-attributes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> index 2055a03cbeb187743e687c2ce3f8a339a2bd4cfc..a61428bfdce372ea0511fb7c3e80f4c43f427eb4 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
> @@ -11,7 +11,7 @@
>  #include <linux/hid-sensor-hub.h>
>  #include <linux/iio/iio.h>
>  
> -static struct {
> +static const struct {
>  	u32 usage_id;
>  	int unit; /* 0 for default others from HID sensor spec */
>  	int scale_val0; /* scale, whole number */
> 
> ---
> base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
> change-id: 20250628-iio-const-data-14-b3250e000af7
> 
> Best regards,