linux-kernel - Re: [PATCH v9 1/8] platform/x86: asus-wmi: export symbols used for read/write WMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202506300004.OWO7f60c-lkp@intel.com>
Date: Mon, 30 Jun 2025 01:08:20 +0800
From: kernel test robot <lkp@...el.com>
To: Denis Benato <benato.denis96@...il.com>, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, hdegoede@...hat.com,
	ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org,
	mario.limonciello@....com, "Luke D . Jones" <luke@...nes.dev>,
	Denis Benato <benato.denis96@...il.com>
Subject: Re: [PATCH v9 1/8] platform/x86: asus-wmi: export symbols used for
 read/write WMI

Hi Denis,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.16-rc3 next-20250627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Denis-Benato/platform-x86-asus-wmi-export-symbols-used-for-read-write-WMI/20250629-211651
base:   linus/master
patch link:    https://lore.kernel.org/r/20250629131423.9013-2-benato.denis96%40gmail.com
patch subject: [PATCH v9 1/8] platform/x86: asus-wmi: export symbols used for read/write WMI
config: arc-randconfig-002-20250629 (https://download.01.org/0day-ci/archive/20250630/202506300004.OWO7f60c-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250630/202506300004.OWO7f60c-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506300004.OWO7f60c-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/hid/hid-asus.c:29:
>> include/linux/platform_data/x86/asus-wmi.h:187:19: error: redefinition of 'asus_wmi_set_devstate'
     187 | static inline int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval)
         |                   ^~~~~~~~~~~~~~~~~~~~~
   include/linux/platform_data/x86/asus-wmi.h:179:19: note: previous definition of 'asus_wmi_set_devstate' with type 'int(u32,  u32,  u32 *)' {aka 'int(unsigned int,  unsigned int,  unsigned int *)'}
     179 | static inline int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval)
         |                   ^~~~~~~~~~~~~~~~~~~~~


vim +/asus_wmi_set_devstate +187 include/linux/platform_data/x86/asus-wmi.h

   165	
   166	#if IS_REACHABLE(CONFIG_ASUS_WMI)
   167	void set_ally_mcu_hack(enum asus_ally_mcu_hack status);
   168	void set_ally_mcu_powersave(bool enabled);
   169	int asus_wmi_get_devstate_dsts(u32 dev_id, u32 *retval);
   170	int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval);
   171	int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, u32 *retval);
   172	#else
   173	static inline void set_ally_mcu_hack(enum asus_ally_mcu_hack status)
   174	{
   175	}
   176	static inline void set_ally_mcu_powersave(bool enabled)
   177	{
   178	}
   179	static inline int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval)
   180	{
   181		return -ENODEV;
   182	}
   183	static inline int asus_wmi_get_devstate_dsts(u32 dev_id, u32 *retval)
   184	{
   185		return -ENODEV;
   186	}
 > 187	static inline int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval)
   188	{
   189		return -ENODEV;
   190	}
   191	static inline int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1,
   192						   u32 *retval)
   193	{
   194		return -ENODEV;
   195	}
   196	#endif
   197	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki