linux-kernel - Re: [PATCH 5/5] media: i2c: imx214: Separat legacy link frequency check from PLL calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250629172028.GM24912@pendragon.ideasonboard.com>
Date: Sun, 29 Jun 2025 20:20:28 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: git@...tzsch.eu
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Ricardo Ribalda <ribalda@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] media: i2c: imx214: Separat legacy link frequency
 check from PLL calculation

Hi André,

Thank you for the patch.

s/Separat/Separate/ in the subject line.

On Sun, Jun 29, 2025 at 04:49:24PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@...tzsch.eu>
> 
> This makes it easier to drop this legacy support from the driver later.
> 
> Signed-off-by: André Apitzsch <git@...tzsch.eu>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/i2c/imx214.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 63cf30acdc241de2f9ab3db339590da4af3d5102..52433775e9baddd8ab988e866a83387d53c1fd5c 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -1362,18 +1362,16 @@ static int imx214_parse_fwnode(struct imx214 *imx214)
>  		u64 freq = bus_cfg->link_frequencies[i];
>  		struct ccs_pll pll;
>  
> -		if (!imx214_pll_calculate(imx214, &pll, freq))
> -			break;
>  		if (freq == IMX214_DEFAULT_LINK_FREQ_LEGACY) {
>  			dev_warn(dev,
>  				 "link-frequencies %d not supported, please review your DT. Continuing anyway\n",
>  				 IMX214_DEFAULT_LINK_FREQ);
>  			freq = IMX214_DEFAULT_LINK_FREQ;
> -			if (imx214_pll_calculate(imx214, &pll, freq))
> -				continue;
>  			bus_cfg->link_frequencies[i] = freq;
> -			break;
>  		}
> +
> +		if (!imx214_pll_calculate(imx214, &pll, freq))
> +			break;
>  	}
>  
>  	if (i == bus_cfg->nr_of_link_frequencies)

-- 
Regards,

Laurent Pinchart