linux-kernel - Re: [PATCH v1 net-next PATCH 1/1] net: phy: air_en8811h: Introduce resume/suspend and clk_restore_context to ensure correct CKO settings after network interface reinitialization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe9a6e67-2790-489b-a5fa-a03ec041f48e@lunn.ch>
Date: Sun, 29 Jun 2025 20:10:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Lucien.Jheng" <lucienzx159@...il.com>
Cc: linux-clk@...r.kernel.org, hkallweit1@...il.com, linux@...linux.org.uk,
	kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, daniel@...rotopia.org, ericwouds@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	joseph.lin@...oha.com, wenshin.chung@...oha.com,
	lucien.jheng@...oha.com, albert-al.lee@...oha.com
Subject: Re: [PATCH v1 net-next PATCH 1/1] net: phy: air_en8811h: Introduce
 resume/suspend and clk_restore_context to ensure correct CKO settings after
 network interface reinitialization.

> +static void en8811h_clk_restore_context(struct clk_hw *hw)
> +{
> +	if (!__clk_get_enable_count(hw->clk))

Using a __ functions seems wrong, they are supposed to be internal.

How about clk_ops save_context() and restore_context()?

    Andrew

---
pw-bot: cr