linux-kernel - Re: [PATCH v3] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c44cf0e9-9510-4fe9-aa67-edeaa1be6253@wanadoo.fr>
Date: Sun, 29 Jun 2025 16:19:42 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Markus Elfring <Markus.Elfring@....de>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org,
 Chen Ni <nichen@...as.ac.cn>, linux-can@...r.kernel.org,
 Marc Kleine-Budde <mkl@...gutronix.de>
Subject: Re: [PATCH v3] can: ucan: Use two USB endpoint API functions rather
 than duplicating their implementations

On 28/06/2025 at 16:19, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 28 Jun 2025 08:56:51 +0200

Your patch doesn't pass the ./script/checkpath.pl script :(

  WARNING: From:/Signed-off-by: email address mismatch: 'From: Markus Elfring
<elfring@...rs.sourceforge.net>' != 'Signed-off-by: Markus Elfring
<Markus.Elfring@....de>'

  total: 0 errors, 1 warnings, 0 checks, 21 lines checked

Please use the same email address:

  - To send the patch

  - For the patch author

  - For the Signed-off-by tag

> * Reuse existing functionality from usb_endpoint_is_bulk_in()
>   and usb_endpoint_is_bulk_out() instead of keeping duplicate source code.
> 
> * Omit two comment lines which became redundant with this refactoring.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Reviewed-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> Signed-off-by: Markus Elfring <Markus.Elfring@....de>

Yours sincerely,
Vincent Mailhol