linux-kernel - Re: [PATCH] platform/x86: dell-wmi-sysman: Fix WMI data block retrieval in sysfs callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DAZF57H19N50.2CQE5TCAK4U0W@gmail.com>
Date: Sun, 29 Jun 2025 20:50:57 -0300
From: "Kurt Borja" <kuurtb@...il.com>
To: "Armin Wolf" <W_Armin@....de>, "Prasanth Ksr" <prasanth.ksr@...l.com>,
 "Hans de Goede" <hansg@...nel.org>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, Thomas Weißschuh
 <linux@...ssschuh.net>, "Mario Limonciello" <mario.limonciello@....com>,
 "Divya Bharathi" <divya.bharathi@...l.com>, "Linus Torvalds"
 <torvalds@...ux-foundation.org>
Cc: <Dell.Client.Kernel@...l.com>, <platform-driver-x86@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Jan Graczyk" <jangraczyk@...oo.ca>
Subject: Re: [PATCH] platform/x86: dell-wmi-sysman: Fix WMI data block
 retrieval in sysfs callbacks

On Sun Jun 29, 2025 at 8:37 PM -03, Armin Wolf wrote:
> Am 29.06.25 um 20:33 schrieb Kurt Borja:
>
>> After retrieving WMI data blocks in sysfs callbacks, check for the
>> validity of them before dereferencing their content.
>>
>> Reported-by: Jan Graczyk <jangraczyk@...oo.ca>
>> Closes: https://lore.kernel.org/r/CAHk-=wgMiSKXf7SvQrfEnxVtmT=QVQPjJdNjfm3aXS7wc=rzTw@mail.gmail.com/
>> Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
>> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
>> Signed-off-by: Kurt Borja <kuurtb@...il.com>
>> ---
>>   drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h    | 7 +++++++
>>   drivers/platform/x86/dell/dell-wmi-sysman/enum-attributes.c    | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/int-attributes.c     | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/passobj-attributes.c | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/string-attributes.c  | 5 +++--
>>   drivers/platform/x86/dell/dell-wmi-sysman/sysman.c             | 8 ++++----
>>   6 files changed, 23 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h b/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h
>> index 3ad33a094588c6a258786a02f952eaa6bf953234..792e7d865bfb1cfc13b59c90ddf7de47feff408f 100644
>> --- a/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h
>> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/dell-wmi-sysman.h
>> @@ -89,6 +89,13 @@ extern struct wmi_sysman_priv wmi_priv;
>>   
>>   enum { ENUM, INT, STR, PO };
>>   
>> +enum {
>> +	ENUM_MIN_ELEMENTS	= 8,
>> +	INT_MIN_ELEMENTS	= 9,
>> +	STR_MIN_ELEMENTS	= 8,
>> +	PO_MIN_ELEMENTS		= 4,
>> +};
>
> Hi,
>
> are you sure that this works? I suggest we use defines instead as ENUM_MIN_ELEMENTS has the same value as STR_MIN_ELEMENTS.

Oh - I wrote that without thinking...

I'm pretty sure it works, but I'll go with defines anyway.

>
> For the rest:
>
> Reviewed-by: Armin Wolf <W_Armin@....de>

Thanks!


-- 
 ~ Kurt