linux-kernel - Re: [PATCH 3/4] tools/nolibc: move FD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <029f24fa-3512-4736-94a0-e158c158cc8e@t-8ch.de>
Date: Sun, 29 Jun 2025 11:37:06 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Willy Tarreau <w@....eu>
Cc: Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] tools/nolibc: move FD_* definitions to sys/select.h

On 2025-06-29 11:25:52+0200, Willy Tarreau wrote:
> On Sun, Jun 29, 2025 at 10:53:34AM +0200, Thomas Weißschuh wrote:
> > On 2025-06-29 10:46:28+0200, Willy Tarreau wrote:
> > > On Mon, Jun 23, 2025 at 04:56:18AM +0200, Willy Tarreau wrote:

<snip>

> > > Trying it has reopened the circular dependencies can of worms :-(
> > > It's the same problem as usual that we've worked around till now
> > > by placing some types in types.h, except that this time fd_set is
> > > defined based on the macros FD_* that I moved to sys/select.h.
> > 
> > Can't fd_set also move to sys/select.h? This is how I read fd_set(3).
> 
> That was what I did and precisely what was causing the problem. We
> have sys.h defining select() with fd_set in it with sys/select not yet
> being included. I moved sys.h after all sys/* and it broke something
> else instead.

Ah. Then move select() also into sys/select.h; where it belongs. :-)

<snip>