[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <282d9d1264c541343462dd7982c4f5dbc029c660.camel@sipsolutions.net>
Date: Mon, 30 Jun 2025 15:37:55 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Wentao Liang <vulab@...as.ac.cn>, ajay.kathat@...rochip.com,
claudiu.beznea@...on.dev, kvalo@...nel.org
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
stable@...r.kernel.org
Subject: Re: [PATCH v2] wifi: wilc1000: Handle wilc_sdio_cmd52() failure in
wilc_sdio_read_init()
On Mon, 2025-05-19 at 09:54 +0800, Wentao Liang wrote:
> The wilc_sdio_read_init() calls wilc_sdio_cmd52() but does not check the
> return value. This could lead to execution with potentially invalid data
> if wilc_sdio_cmd52() fails. A proper implementation can be found in
> wilc_sdio_read_reg().
This seems fairly much pointless, if the caller is never going to check
the return value anyway?
> 2.42.0.windows.2
Really? Did you even _build_ the changes yourself?
johannes
Powered by blists - more mailing lists