linux-kernel - Re: [PATCH] regulator: sy8827n: make enable gpio NONEXCLUSIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McPmYLhPrRnkZAQWHX+wF2PvYhDE5rD_Ws5ExSB2sGPXw@mail.gmail.com>
Date: Mon, 30 Jun 2025 15:40:32 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH] regulator: sy8827n: make enable gpio NONEXCLUSIVE

On Sun, Jun 29, 2025 at 12:14 PM Jisheng Zhang <jszhang@...nel.org> wrote:
>
> On some platforms, the sy8827n enable gpio may also be used for other
> purpose, so make it NONEXCLUSIVE to support this case.
>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  drivers/regulator/sy8827n.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/sy8827n.c b/drivers/regulator/sy8827n.c
> index f11ff38b36c9..0b811514782f 100644
> --- a/drivers/regulator/sy8827n.c
> +++ b/drivers/regulator/sy8827n.c
> @@ -140,7 +140,8 @@ static int sy8827n_i2c_probe(struct i2c_client *client)
>                 return -EINVAL;
>         }
>
> -       di->en_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH);
> +       di->en_gpio = devm_gpiod_get_optional(dev, "enable",
> +                       GPIOD_OUT_HIGH | GPIOD_FLAGS_BIT_NONEXCLUSIVE);
>         if (IS_ERR(di->en_gpio))
>                 return PTR_ERR(di->en_gpio);
>
> --
> 2.49.0
>

As explained in the discussion about this flag: I hate this but I
haven't yet gotten around to proposing an alternative, so reluctantly:

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>