linux-kernel - Re: [PATCH v14 21/32] fs/resctrl: Pass entire struct rdtgroup rather than passing individual members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac378dff-3eb1-498c-8b01-b7c5146c96bd@amd.com>
Date: Mon, 30 Jun 2025 08:57:02 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>,
 "Moger, Babu" <Babu.Moger@....com>, "corbet@....net" <corbet@....net>,
 "tony.luck@...el.com" <tony.luck@...el.com>,
 "Dave.Martin@....com" <Dave.Martin@....com>,
 "james.morse@....com" <james.morse@....com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
Cc: "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
 "rostedt@...dmis.org" <rostedt@...dmis.org>,
 "paulmck@...nel.org" <paulmck@...nel.org>,
 "thuth@...hat.com" <thuth@...hat.com>, "ardb@...nel.org" <ardb@...nel.org>,
 "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
 "seanjc@...gle.com" <seanjc@...gle.com>,
 "Lendacky, Thomas" <Thomas.Lendacky@....com>,
 "pawan.kumar.gupta@...ux.intel.com" <pawan.kumar.gupta@...ux.intel.com>,
 "Shukla, Manali" <Manali.Shukla@....com>, "Yuan, Perry"
 <Perry.Yuan@....com>, "kai.huang@...el.com" <kai.huang@...el.com>,
 "peterz@...radead.org" <peterz@...radead.org>,
 "xiaoyao.li@...el.com" <xiaoyao.li@...el.com>,
 "kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>,
 "Limonciello, Mario" <Mario.Limonciello@....com>,
 "xin3.li@...el.com" <xin3.li@...el.com>,
 "Shenoy, Gautham Ranjal" <gautham.shenoy@....com>,
 "xin@...or.com" <xin@...or.com>,
 "chang.seok.bae@...el.com" <chang.seok.bae@...el.com>,
 "fenghuay@...dia.com" <fenghuay@...dia.com>,
 "peternewman@...gle.com" <peternewman@...gle.com>,
 "maciej.wieczor-retman@...el.com" <maciej.wieczor-retman@...el.com>,
 "eranian@...gle.com" <eranian@...gle.com>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 21/32] fs/resctrl: Pass entire struct rdtgroup rather
 than passing individual members

Hi Reinette,

On 6/24/2025 11:18 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 6/13/25 2:05 PM, Babu Moger wrote:
>> Reading the monitoring data requires RMID, CLOSID, and event ID, among
>> other parameters. These are passed individually, resulting in architecture
> 
> It is not clear how "event ID" and "other parameters" are relevant to this
> change since (in this context) it is only RMID and CLOSID that can be
> found in rdtgroup.
> 
>> specific function calls.
> 
> Could you please elaborate what you meant with: "These are passed individually,
> resulting in architecture specific function calls."?

Rephrased the whole changelog.

"fs/resctrl: Pass the full rdtgroup structure instead of individual RMID
and CLOSID

The functions resctrl_arch_reset_rmid() and resctrl_arch_rmid_read()
require several parameters, including RMID and CLOSID. Currently, RMID and
CLOSID are passed individually, even though they are available within the
rdtgroup structure.

Refactor the code to pass a pointer to struct rdtgroup instead of
individual members in preparation for this requirement.

Additionally, when "mbm_event" counter assignment mode is enabled, a
counter ID is required to read the event. The counter ID is obtained
through mbm_cntr_get(), which expects a struct rdtgroup pointer."


Thanks
Babu