linux-kernel - Re: [PATCH 30/66] kconfig: gconf: remove glade_xml_signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNARyr7xtjhVTV=Rs4WqbP6YQN90Xbb5N=snEyjdXqUGDBQ@mail.gmail.com>
Date: Mon, 30 Jun 2025 13:14:27 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 30/66] kconfig: gconf: remove glade_xml_signal_autoconnect()
 call

On Mon, Jun 30, 2025 at 11:58 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
>
>
> On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> > Now that all signals are connected manually, this is no longer
> > unnecessary.
>
> Double negative. Or is that what you meant?
>
> is no longer necessary.
> is now unnecessary.


is no longer necessary.

I will fix it. Thanks.






> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> > ---
> >
> >  scripts/kconfig/gconf.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> > index 02bbb7ce4c4a..09537245213a 100644
> > --- a/scripts/kconfig/gconf.c
> > +++ b/scripts/kconfig/gconf.c
> > @@ -1120,7 +1120,6 @@ static void init_main_window(const gchar *glade_file)
> >       xml = glade_xml_new(glade_file, "window1", NULL);
> >       if (!xml)
> >               g_error("GUI loading failed !\n");
> > -     glade_xml_signal_autoconnect(xml);
> >
> >       main_wnd = glade_xml_get_widget(xml, "window1");
> >       g_signal_connect(main_wnd, "destroy",
>
> --
> ~Randy
>
>


-- 
Best Regards
Masahiro Yamada