linux-kernel - Re: [PATCH v5 09/14] sched/debug: Add support to change sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250630152616.GA2447467@joelnvbox>
Date: Mon, 30 Jun 2025 11:26:16 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: Tejun Heo <tj@...nel.org>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	David Vernet <void@...ifault.com>, Andrea Righi <arighi@...dia.com>,
	Changwoo Min <changwoo@...lia.com>
Subject: Re: [PATCH v5 09/14] sched/debug: Add support to change sched_ext
 server params

Hi Tejun,

On Mon, Jun 23, 2025 at 12:12:32 -1000, Tejun Heo wrote:
> On Fri, Jun 20, 2025 at 04:32:24PM -0400, Joel Fernandes wrote:
> ...
> > -		if (!runtime)
> > -			printk_deferred("Fair server disabled in CPU %d, system may crash due to starvation.\n",
> > -					cpu_of(rq));
> > +		if (!runtime) {
> > +			if (server == &rq->fair_server)
> > +				printk_deferred("Fair server disabled on CPU %d, system may crash due to starvation.\n",
> > +						cpu_of(rq));
> > +			else
> > +				printk_deferred("Ext server disabled on CPU %d, system may crash due to starvation.\n",
> > +						cpu_of(rq));
> 
> It's minor but the above is a bit ugly. Maybe pass in the name as an arg or
> put it in dl_se?

Thanks, I changed it to the following for the next revision, which is
indeed cleaner:

	printk_deferred("%s server disabled on CPU %d, system may crash due to starvation.\n",
			server == &rq->fair_server ? "Fair" : "Ext", cpu_of(rq));


thanks,

 - Joel