linux-kernel - Re: [PATCH] perf test: perf header test fails on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWGiitgromQRTxEsU3cY99gFAU6WPLnmiS7-Q8vQNGbYw@mail.gmail.com>
Date: Mon, 30 Jun 2025 08:42:01 -0700
From: Ian Rogers <irogers@...gle.com>
To: Thomas Richter <tmricht@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org, 
	linux-perf-users@...r.kernel.org, acme@...nel.org, namhyung@...nel.org, 
	agordeev@...ux.ibm.com, gor@...ux.ibm.com, sumanthk@...ux.ibm.com, 
	hca@...ux.ibm.com, japo@...ux.ibm.com
Subject: Re: [PATCH] perf test: perf header test fails on s390

On Mon, Jun 30, 2025 at 2:16 AM Thomas Richter <tmricht@...ux.ibm.com> wrote:
>
> commit 2d584688643fa ("perf test: Add header shell test")
> introduced a new test case for perf header. It fails on s390
> because call graph option -g is not supported on s390.
> Also the option --call-graph dwarf is only supported for
> the event cpu-clock.
>
> Remove this option and the test succeeds.
>
> Output after:
>  # ./perf test 76
>  76: perf header tests                           : Ok
>
> Fixes: 2d584688643fa ("perf test: Add header shell test")
> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> Acked-by: Sumanth Korikkar <sumanthk@...ux.ibm.com>
> Cc: Ian Rogers <irogers@...gle.com>

Thanks Thomas! Given the s390 restriction to require dwarf, should we
switch the default "-g" meaning on s390 to mean use dwarf? James Clark
proposed this previously. It doesn't affect the change here so:

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/header.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/header.sh b/tools/perf/tests/shell/header.sh
> index 813831cff0bd..412263de6ed7 100755
> --- a/tools/perf/tests/shell/header.sh
> +++ b/tools/perf/tests/shell/header.sh
> @@ -51,7 +51,7 @@ check_header_output() {
>  test_file() {
>    echo "Test perf header file"
>
> -  perf record -o "${perfdata}" -g -- perf test -w noploop
> +  perf record -o "${perfdata}" -- perf test -w noploop
>    perf report --header-only -I -i "${perfdata}" > "${script_output}"
>    check_header_output
>
> @@ -61,7 +61,7 @@ test_file() {
>  test_pipe() {
>    echo "Test perf header pipe"
>
> -  perf record -o - -g -- perf test -w noploop | perf report --header-only -I -i - > "${script_output}"
> +  perf record -o - -- perf test -w noploop | perf report --header-only -I -i - > "${script_output}"
>    check_header_output
>
>    echo "Test perf header pipe [Done]"
> --
> 2.50.0
>