linux-kernel - Re: [PATCH v5 10/14] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e9ddbe4-c94c-4087-8b34-0407ea278888@cixtech.com>
Date: Mon, 30 Jun 2025 23:54:33 +0800
From: Hans Zhang <hans.zhang@...tech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
 fugang.duan@...tech.com, guoyin.chen@...tech.com, peter.chen@...tech.com,
 cix-kernel-upstream@...tech.com, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 10/14] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex
 bindings



On 2025/6/30 15:26, Krzysztof Kozlowski wrote:
>> +  sky1,pcie-ctrl-id:
>> +    description: |
>> +      Specifies the PCIe controller instance identifier (0-4).
> No, you don't get an instance ID. Drop the property and look how other
> bindings encoded it (not sure about the purpose and you did not explain
> it, so cannot advise).


Dear Krzysztof,

Sorry, I missed your reply to this in the previous email.

Because our Root Port driver needs to support 5 PCIe ports, and the 
register configuration and offset of each port are different, it is 
necessary to know which port it is currently. Perhaps I can use the 
following method and then delete this attribute.

aliases {
		......
		pcie_rc0 = &pcie_x8_rc;
		pcie_rc1 = &pcie_x4_rc;
		pcie_rc2 = &pcie_x2_rc;
		pcie_rc3 = &pcie_x1_0_rc;
		pcie_rc4 = &pcie_x1_1_rc;
		
id = of_alias_get_id(dev->of_node, "pcie_rc");

Best regards,
Hans