linux-kernel - Re: [PATCH v4 3/5] iommu: Add verisilicon IOMMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05a7c67f-d1fa-4ad4-a794-cc081cd04abc@collabora.com>
Date: Mon, 30 Jun 2025 18:44:12 +0200
From: Benjamin Gaignard <benjamin.gaignard@...labora.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, oe-kbuild@...ts.linux.dev,
 joro@...tes.org, will@...nel.org, robin.murphy@....com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de,
 nicolas.dufresne@...labora.com, jgg@...pe.ca
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, iommu@...ts.linux.dev,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 kernel@...labora.com
Subject: Re: [PATCH v4 3/5] iommu: Add verisilicon IOMMU driver


Le 30/06/2025 à 18:13, Dan Carpenter a écrit :
> Hi Benjamin,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/dt-bindings-vendor-prefixes-Add-Verisilicon/20250623-234734
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link:    https://lore.kernel.org/r/20250623153931.158765-4-benjamin.gaignard%40collabora.com
> patch subject: [PATCH v4 3/5] iommu: Add verisilicon IOMMU driver
> config: alpha-randconfig-r073-20250627 (https://download.01.org/0day-ci/archive/20250629/202506290711.T0HOr5wS-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 8.5.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> | Closes: https://lore.kernel.org/r/202506290711.T0HOr5wS-lkp@intel.com/
>
> smatch warnings:
> drivers/iommu/vsi-iommu.c:657 vsi_iommu_probe() error: uninitialized symbol 'err'.
>
> vim +/err +657 drivers/iommu/vsi-iommu.c
>
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  639  static int vsi_iommu_probe(struct platform_device *pdev)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  640  {
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  641  	struct device *dev = &pdev->dev;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  642  	struct vsi_iommu *iommu;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  643  	int err;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  644
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  645  	iommu = devm_kzalloc(dev, sizeof(*iommu), GFP_KERNEL);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  646  	if (!iommu)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  647  		return -ENOMEM;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  648
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  649  	iommu->dev = dev;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  650
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  651  	iommu->regs = devm_platform_ioremap_resource(pdev, 0);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  652  	if (IS_ERR(iommu->regs))
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  653  		return -ENOMEM;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  654
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  655  	iommu->num_clocks = devm_clk_bulk_get_all(dev, &iommu->clocks);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  656  	if  (iommu->num_clocks < 0)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23 @657  		return err;
>
> s/err/iommu->num_clocks/

I will fix that in next version but I will wait for more
comments/review before send it.

Regards,
Benjamin

>
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  658
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  659  	err = clk_bulk_prepare(iommu->num_clocks, iommu->clocks);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  660  	if (err)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  661  		return err;
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  662
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  663  	iommu->irq = platform_get_irq(pdev, 0);
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  664  	if (iommu->irq < 0)
> 15ea72d5401fb7 Benjamin Gaignard 2025-06-23  665  		return iommu->irq;
>