linux-kernel - Re: [PATCH v1 0/3] cgroup: Add lock guard support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <zrl7ijmx6vrzcmmnxojgbkmhjymrpuhcjh3sc6py622abn5iee@qmbmkcwnnzgd>
Date: Mon, 30 Jun 2025 19:39:56 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Tejun Heo <tj@...nel.org>, Jemmy Wong <jemmywong512@...il.com>, 
	Waiman Long <longman@...hat.com>, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] cgroup: Add lock guard support

On Mon, Jun 23, 2025 at 04:03:21PM +0200, Johannes Weiner <hannes@...xchg.org> wrote:
> > People can argue these things to high heavens on abstract grounds,
> > but if you break it down to practical gains vs. costs, it's not a
> > huge difference.

This makes it sound like we were discussing tabs-vs-spaces (at least I
perceive there are more benefits of guard locks ;-))

(I also believe that the encouraged separation per lock (locking type)
would allow easier backporting of this transformation.)

> > But, again, I'm not against it. Johannes, any second thoughts?
> 
> Yeah, letting the primitives get used organically in new code and
> patches sounds better to me than retrofitting it into an existing
> function graph that wasn't designed with these in mind.

But OK, it sounds there's no objection against combining *_lock calling-
and guarded code at one time, so in the future the ratio of those two
may be more favorable for one-time switch to the latter.

I thank Jemmy for giving the preview of the transformation.


Michal


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)