linux-kernel - Re: [PATCH] EDAC/amd64: replace sprintf with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025063001-marigold-renewed-6361@gregkh>
Date: Mon, 30 Jun 2025 07:06:58 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Marcelo Moreira <marcelomoreira1905@...il.com>
Cc: Yazen Ghannam <yazen.ghannam@....com>, skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	~lkcamp/patches@...ts.sr.ht, Borislav Petkov <bp@...en8.de>,
	Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd64: replace sprintf with sysfs_emit in show
 functions

On Sun, Jun 29, 2025 at 03:24:48PM -0300, Marcelo Moreira wrote:
> Update all device attribute 'show' callbacks in the EDAC AMD64 driver to
> utilize sysfs_emit(). This change adheres to the recommendation outlined
> in Documentation/filesystems/sysfs.rst.
> 
> This modification aligns with current sysfs subsystem guidelines.
> 
> Signed-off-by: Marcelo Moreira <marcelomoreira1905@...il.com>
> ---
>  drivers/edac/amd64_edac.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index b681c0663203..b6d211255ef0 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -552,7 +552,7 @@ static ssize_t reg##_show(struct device *dev,				\
>  	struct mem_ctl_info *mci = to_mci(dev);				\
>  	struct amd64_pvt *pvt = mci->pvt_info;				\
>  									\
> -	return sprintf(data, "0x%016llx\n", (u64)pvt->reg);		\
> +	return  sysfs_emit(data, "0x%016llx\n", (u64)pvt->reg);		\

Why the extra ' '?


>  }
>  
>  EDAC_DCT_ATTR_SHOW(dhar);
> @@ -571,7 +571,7 @@ static ssize_t dram_hole_show(struct device *dev, struct device_attribute *mattr
>  
>  	get_dram_hole_info(mci, &hole_base, &hole_offset, &hole_size);
>  
> -	return sprintf(data, "%llx %llx %llx\n", hole_base, hole_offset,
> +	return sysfs_emit(data, "%llx %llx %llx\n", hole_base, hole_offset,
>  						 hole_size);
>  }
>  
> @@ -602,7 +602,7 @@ static ssize_t inject_section_show(struct device *dev,
>  {
>  	struct mem_ctl_info *mci = to_mci(dev);
>  	struct amd64_pvt *pvt = mci->pvt_info;
> -	return sprintf(buf, "0x%x\n", pvt->injection.section);
> +	return sysfs_emit(buf, "0x%x\n", pvt->injection.section);
>  }
>  
>  /*
> @@ -638,7 +638,7 @@ static ssize_t inject_word_show(struct device *dev,
>  {
>  	struct mem_ctl_info *mci = to_mci(dev);
>  	struct amd64_pvt *pvt = mci->pvt_info;
> -	return sprintf(buf, "0x%x\n", pvt->injection.word);
> +	return sysfs_emit(buf, "0x%x\n", pvt->injection.word);
>  }
>  
>  /*
> @@ -675,7 +675,7 @@ static ssize_t inject_ecc_vector_show(struct device *dev,
>  {
>  	struct mem_ctl_info *mci = to_mci(dev);
>  	struct amd64_pvt *pvt = mci->pvt_info;
> -	return sprintf(buf, "0x%x\n", pvt->injection.bit_map);
> +	return sysfs_emit(buf, "0x%x\n", pvt->injection.bit_map);

There's nothing wrong with these sprintf() lines, so no need to change
them, right?

I only recommend making this type of change when adding new sysfs files,
no need for churn on old files when it is not needed at all.

thanks,

greg k-h