| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202506300705.3Sj0EHmY-lkp@intel.com>
Date: Mon, 30 Jun 2025 07:18:31 +0200
From: kernel test robot <lkp@...el.com>
To: Oliver Neukum <oneukum@...e.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Colin Ian King <colin.i.king@...il.com>
Subject: drivers/scsi/dc395x.c:2185:13: warning: variable 'fact' set but not
used
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af
commit: 62b434b0db2cdc21d6fe978d24d8f84e473cb5e7 scsi: dc395x: Remove DEBUG conditional compilation
date: 9 weeks ago
config: loongarch-randconfig-2006-20250625 (https://download.01.org/0day-ci/archive/20250630/202506300705.3Sj0EHmY-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250630/202506300705.3Sj0EHmY-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506300705.3Sj0EHmY-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/scsi/dc395x.c: In function 'msgin_set_sync':
>> drivers/scsi/dc395x.c:2185:13: warning: variable 'fact' set but not used [-Wunused-but-set-variable]
2185 | int fact;
| ^~~~
vim +/fact +2185 drivers/scsi/dc395x.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 2178
^1da177e4c3f41 Linus Torvalds 2005-04-16 2179
^1da177e4c3f41 Linus Torvalds 2005-04-16 2180 /* set sync transfer mode */
^1da177e4c3f41 Linus Torvalds 2005-04-16 2181 static void msgin_set_sync(struct AdapterCtlBlk *acb, struct ScsiReqBlk *srb)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2182 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2183 struct DeviceCtlBlk *dcb = srb->dcb;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2184 u8 bval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2185 int fact;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2186
^1da177e4c3f41 Linus Torvalds 2005-04-16 2187 if (srb->msgin_buf[4] > 15)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2188 srb->msgin_buf[4] = 15;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2189 if (!(dcb->dev_mode & NTC_DO_SYNC_NEGO))
^1da177e4c3f41 Linus Torvalds 2005-04-16 2190 dcb->sync_offset = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2191 else if (dcb->sync_offset == 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2192 dcb->sync_offset = srb->msgin_buf[4];
^1da177e4c3f41 Linus Torvalds 2005-04-16 2193 if (srb->msgin_buf[4] > dcb->sync_offset)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2194 srb->msgin_buf[4] = dcb->sync_offset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2195 else
^1da177e4c3f41 Linus Torvalds 2005-04-16 2196 dcb->sync_offset = srb->msgin_buf[4];
^1da177e4c3f41 Linus Torvalds 2005-04-16 2197 bval = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2198 while (bval < 7 && (srb->msgin_buf[3] > clock_period[bval]
^1da177e4c3f41 Linus Torvalds 2005-04-16 2199 || dcb->min_nego_period >
^1da177e4c3f41 Linus Torvalds 2005-04-16 2200 clock_period[bval]))
^1da177e4c3f41 Linus Torvalds 2005-04-16 2201 bval++;
62b434b0db2cdc Oliver Neukum 2025-04-28 2202
^1da177e4c3f41 Linus Torvalds 2005-04-16 2203 srb->msgin_buf[3] = clock_period[bval];
^1da177e4c3f41 Linus Torvalds 2005-04-16 2204 dcb->sync_period &= 0xf0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2205 dcb->sync_period |= ALT_SYNC | bval;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2206 dcb->min_nego_period = srb->msgin_buf[3];
^1da177e4c3f41 Linus Torvalds 2005-04-16 2207
^1da177e4c3f41 Linus Torvalds 2005-04-16 2208 if (dcb->sync_period & WIDE_SYNC)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2209 fact = 500;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2210 else
^1da177e4c3f41 Linus Torvalds 2005-04-16 2211 fact = 250;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2212
^1da177e4c3f41 Linus Torvalds 2005-04-16 2213 if (!(srb->state & SRB_DO_SYNC_NEGO)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2214 /* Reply with corrected SDTR Message */
^1da177e4c3f41 Linus Torvalds 2005-04-16 2215
^1da177e4c3f41 Linus Torvalds 2005-04-16 2216 memcpy(srb->msgout_buf, srb->msgin_buf, 5);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2217 srb->msg_count = 5;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2218 DC395x_ENABLE_MSGOUT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2219 dcb->sync_mode |= SYNC_NEGO_DONE;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2220 } else {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2221 if ((dcb->sync_mode & WIDE_NEGO_ENABLE)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2222 && !(dcb->sync_mode & WIDE_NEGO_DONE)) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2223 build_wdtr(acb, dcb, srb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2224 DC395x_ENABLE_MSGOUT;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2225 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2226 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2227 srb->state &= ~SRB_DO_SYNC_NEGO;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2228 dcb->sync_mode |= SYNC_NEGO_DONE | SYNC_NEGO_ENABLE;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2229
^1da177e4c3f41 Linus Torvalds 2005-04-16 2230 reprogram_regs(acb, dcb);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2231 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2232
:::::: The code at line 2185 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists