linux-kernel - Re: [PATCH v13 5/5] serial: sh-sci: Add support for RZ/T2H SCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8uNoyFUDiq8+_-tY7Kx12R++bkYWdLxP3cmKZ4z9rpBdA@mail.gmail.com>
Date: Mon, 30 Jun 2025 21:10:30 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-serial@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v13 5/5] serial: sh-sci: Add support for RZ/T2H SCI

Hi Greg,

Thank you for the review.

On Sun, Jun 29, 2025 at 1:28 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Sat, Jun 28, 2025 at 12:57:15PM +0100, Prabhakar wrote:
> > +EXPORT_SYMBOL(sci_port_enable);
>
> EXPORT_SYMBOL_GPL() perhaps?  (sorry, I have to ask).
>
I agree EXPORT_SYMBOL_GPL() should have been used as module license is GPL.

> Also, why not limit this to just this one other driver that you want to
> use it with the proper namespace usage instead?
>
Good point, I will switch to using namespaces.

Cheers,
Prabhakar