linux-kernel - Re: [PATCH liburing] liburing.h: Only use `IOURINGINLINE` macro for FFI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOG64qM-zfnBTX1xaGvab7+0i=07G-pasWbS8vkis1M4A1uxLw@mail.gmail.com>
Date: Tue, 1 Jul 2025 03:41:19 +0700
From: Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>
To: Ammar Faizi <ammarfaizi2@...weeb.org>
Cc: Jens Axboe <axboe@...nel.dk>, io-uring Mailing List <io-uring@...r.kernel.org>, 
	"GNU/Weeb Mailing List" <gwml@...r.gnuweeb.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Christian Mazakas <christian.mazakas@...il.com>
Subject: Re: [PATCH liburing] liburing.h: Only use `IOURINGINLINE` macro for
 FFI functions

On Tue, Jul 1, 2025 at 3:36 AM Ammar Faizi wrote:
> These 3 inline functions are for liburing internal use, it does not
> make much sense to export them:
>
>   uring_ptr_to_u64
>   io_uring_cqe_iter_init
>   io_uring_cqe_iter_next
>
> Don't use IOURINGINLINE on them. Also, add a comment on the
> IOURINGINLINE macro definition explaining when to use IOURINGINLINE
> and remind the reader to add the exported function to liburing-ffi.map
> if they introduce a function marked with IOURINGINLINE.
>
> Cc: Christian Mazakas <christian.mazakas@...il.com>
> Cc: Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>
> Signed-off-by: Ammar Faizi <ammarfaizi2@...weeb.org>

Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>