linux-kernel - Re: [PATCH 57/66] kconfig: gconf: replace "tooltip" property with "tooltip-text"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f6cba18-60fe-4472-b186-2db0cf7fc0c5@infradead.org>
Date: Sun, 29 Jun 2025 22:36:03 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 57/66] kconfig: gconf: replace "tooltip" property with
 "tooltip-text"



On 6/24/25 8:05 AM, Masahiro Yamada wrote:
> This was replaced with "tooltip-text" in GtkBuilder with GTK 3.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>


Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

One nit below:

> ---
> 
>  scripts/kconfig/gconf.glade | 34 +++++++++++++++++-----------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/scripts/kconfig/gconf.glade b/scripts/kconfig/gconf.glade
> index c0ada331a5bf..c3996f4635e9 100644
> --- a/scripts/kconfig/gconf.glade
> +++ b/scripts/kconfig/gconf.glade
> @@ -230,7 +230,7 @@
>  	      <child>
>  		<widget class="GtkToolButton" id="button1">
>  		  <property name="visible">True</property>
> -		  <property name="tooltip" translatable="yes">Goes up of one level (single view)</property>
> +		  <property name="tooltip-text" translatable="yes">Goes up of one level (single view)</property>

You didn't change the text here, but this would read better as

  Goes up by one level
or
  Goes up one level

I.e., drop the "of".

-- 
~Randy