linux-kernel - Re: [PATCH v14 21/32] fs/resctrl: Pass entire struct rdtgroup rather than passing individual members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9def123d-d92c-4e79-a5fb-f8761b15200c@intel.com>
Date: Mon, 30 Jun 2025 14:59:24 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: <babu.moger@....com>, "corbet@....net" <corbet@....net>,
	"tony.luck@...el.com" <tony.luck@...el.com>, "Dave.Martin@....com"
	<Dave.Martin@....com>, "james.morse@....com" <james.morse@....com>,
	"tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com"
	<mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>, "paulmck@...nel.org"
	<paulmck@...nel.org>, "thuth@...hat.com" <thuth@...hat.com>,
	"ardb@...nel.org" <ardb@...nel.org>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "seanjc@...gle.com" <seanjc@...gle.com>,
	"Lendacky, Thomas" <Thomas.Lendacky@....com>,
	"pawan.kumar.gupta@...ux.intel.com" <pawan.kumar.gupta@...ux.intel.com>,
	"Shukla, Manali" <Manali.Shukla@....com>, "Yuan, Perry" <Perry.Yuan@....com>,
	"kai.huang@...el.com" <kai.huang@...el.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "xiaoyao.li@...el.com" <xiaoyao.li@...el.com>,
	"kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>, "Limonciello, Mario"
	<Mario.Limonciello@....com>, "xin3.li@...el.com" <xin3.li@...el.com>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@....com>, "xin@...or.com"
	<xin@...or.com>, "chang.seok.bae@...el.com" <chang.seok.bae@...el.com>,
	"fenghuay@...dia.com" <fenghuay@...dia.com>, "peternewman@...gle.com"
	<peternewman@...gle.com>, "maciej.wieczor-retman@...el.com"
	<maciej.wieczor-retman@...el.com>, "eranian@...gle.com" <eranian@...gle.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 21/32] fs/resctrl: Pass entire struct rdtgroup rather
 than passing individual members

Hi Babu,

On 6/30/25 1:58 PM, Moger, Babu wrote:
> 
> How does this look?
> 
> "fs/resctrl: Pass struct rdtgroup instead of individual members
> 
> Reading monitoring data for a resctrl group requires both the RMID and
> CLOSID. These parameters are passed to functions like __mon_event_count(),
> mbm_bw_count(), mbm_update_one_event(), and mbm_update(), where they are
> ultimately used to retrieve event data.
> 
> When "mbm_event" counter assignment mode is enabled, a counter ID is
> required to read the event. The counter ID is obtained through
> mbm_cntr_get(), which expects a struct rdtgroup pointer.
> 
> Passing the pointer to the full rdtgroup structure simplifies access to
> these parameters. Refactor the code to pass a pointer to struct rdtgroup
> instead of individual members in preparation for this requirement."

This looks good. I made a few adjustments that result in below. What do you think?

  Reading monitoring data for a monitoring group requires both the RMID and
  CLOSID. The RMID and CLOSID are members of struct rdtgroup but passed
  separately to several functions involved in retrieving event data.

  When "mbm_event" counter assignment mode is enabled, a counter ID is
  required to read event data. The counter ID is obtained through
  mbm_cntr_get(), which expects a struct rdtgroup pointer.

  Provide a pointer to the struct rdtgroup as parameter to functions
  involved in retrieving event data to simplify access to RMID, CLOSID,
  and counter ID.
 
Reinette